Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: quick allocation #846

Merged
merged 1 commit into from
Apr 29, 2023
Merged

feat: quick allocation #846

merged 1 commit into from
Apr 29, 2023

Conversation

malfynnction
Copy link
Contributor

See #514

@malfynnction malfynnction requested a review from a team as a code owner April 28, 2023 12:14
@malfynnction malfynnction force-pushed the quick-allocation branch 2 times, most recently from b3da84f to a6bfec6 Compare April 28, 2023 12:29
@malfynnction
Copy link
Contributor Author

This can't be merged yet because Quick Allocations will create allocations with amount 0. This will lead to errors when you try to edit these allocation later because we assume that allocation with amount 0 means there is no allocation yet and try to create a new one:

const response =
Number(envelope.allocation) === 0
? createAllocation()
: updateAllocation()

@morremeyer
Copy link
Member

Allocations have been updated to ensure they never have an amount of 0.

The API links will be reworked in API version 2 with envelope-zero/backend#667.

@malfynnction malfynnction enabled auto-merge (rebase) April 29, 2023 16:50
@malfynnction malfynnction merged commit add5d02 into main Apr 29, 2023
@malfynnction malfynnction deleted the quick-allocation branch April 29, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants